-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve dialog shown after publishing scheduled/private stories #13478
Merged
swissspidy
merged 3 commits into
main
from
fix/13472-enhance-postpublish-dialog-wordings
Oct 27, 2023
Merged
Improve dialog shown after publishing scheduled/private stories #13478
swissspidy
merged 3 commits into
main
from
fix/13472-enhance-postpublish-dialog-wordings
Oct 27, 2023
+20
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnuragVasanwala
added
Type: Enhancement
New feature or improvement of an existing feature
Package: WP Story Editor
/packages/wp-story-editor
labels
Oct 18, 2023
Size Change: +72 B (0%) Total Size: 2.75 MB ℹ️ View Unchanged
|
Plugin builds for 24be443 are ready 🛎️!
|
swissspidy
changed the title
♻️ Enhance
Improve dialog shown after publishing scheduled/private stories
Oct 27, 2023
PostPublishDialog
wording for scheduled
and private
…
swissspidy
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Package: WP Story Editor
/packages/wp-story-editor
Type: Enhancement
New feature or improvement of an existing feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of the PR is to display separate message for post publish and schedule scenario.
Summary
Creating a new Scheduled Story and clicking on
Schedule
button showsStory published.
message. In case of Scheduled Story,title
anddescription
of the feedback dialog needs to be corrected.User-facing changes
Testing Instructions
Follow #13472 for the testing instruction.
Reviews
Does this PR have a security-related impact?
No.
Does this PR change what data or activity we track or use?
No.
Does this PR have a legal-related impact?
No.
Checklist
Type: XYZ
label to the PRFixes #13472